Barak Azulay has posted comments on this change.
Change subject: packaging: enable ovirt installation on lower ports
......................................................................
Patch Set 1: (6 inline comments)
please see comments inside
....................................................
File packaging/fedora/setup/engine-setup.py
Line 103: 'functions' :
[_configureSelinuxBoolean, _backupOldHttpdConfig, _exportPrivateKey,
_listenHttpPort, _listenHttpsPort]},
need to add also _redirectUrl
Line 625: backupFile = "%s.%s.%i" % (basedefs.FILE_HTTPD_CONF, "BACKUP",
random.randint(1000000,9999999))
why do we use rnd ?
why not use the datetime of the execution ?
This comment is correct for all the paces we use rnd as a part of the file
name for backup.
Line 635: ###TODO####
if we backup the entire directory - no need to handle ssl.conf individually
Line 649: handler.editParam("SSLCertificateKeyFile",
"/etc/pki/ovirt-engine/keys/engine_id_rsa")
We need to use a proper SSL key (either extract from keystore, or produce a new
one for HTTPD, or work directly with the keystore)
....................................................
File packaging/fedora/setup/output_messages.py
Line 350:
need to check proper English
....................................................
File packaging/fedora/setup/ovirt_port80.py
Line 62: handler.editParam("SSLCertificateKeyFile",
"/etc/pki/ovirt-engine/keys/engine_id_rsa")
we should use a proper SSL key.
Need to check if we can work with the keystore directly
--
To view, visit http://gerrit.ovirt.org/2613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e2f73dde1b599df422816fd7071584cd0aebb39
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Mansano <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
