Michael Kublin has posted comments on this change.
Change subject: DO NOT SUBMIT core: Fixing MoveOrCopyImageGroup to support new
param fields
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
-1, because of the code will cause to regression
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
Line 94: .getId(),
It is wrong, u don't need a destStorageId - the field storageId is used to mark
a destStorageId, here u change a sourceId to destId.
Line 109: } else {
Also, u did changes at copy but not at move?
--
To view, visit http://gerrit.ovirt.org/2655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I628a25e2f5fc4c8cab4d854e7c2d41289d7f9639
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
