Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Introducing AddVmAndCloneImageCommand
......................................................................
Patch Set 9: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
Line 74: params.setVolumeFormat(diskImage.getvolume_format());
Shouldn't this be the ancestor's format?
Line 75: params.setVolumeType(diskImage.getvolume_type());
Ditto..
Line 115:
retDiskImage.setvolume_format(srcDiskImage.getvolume_format());
Shouldn't this be the ancestor's format?
Line 116: retDiskImage.setvolume_type(srcDiskImage.getvolume_type());
Ditto..
Line 205: protected abstract Map<String, DiskImage> getDiskMap();
Why Map if you only access the values?
Line 208: protected DiskImage
getDiskImageToRemoveByParam(VdcActionParametersBase param) {
minor: You don't have to specify 'ByParam' in the method name
--
To view, visit http://gerrit.ovirt.org/2656
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ff02972a4bfaa5696ac07eab7f825468fc52dfe
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
