Oved Ourfali has posted comments on this change. Change subject: core: add mandatory field to cluster networks ......................................................................
Patch Set 14: (2 inline comments) see comments. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java Line 89: NetworkStatus.Operational.getValue(), false, false)); default should be true. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java Line 101: NetworkStatus.Operational.getValue(), true, false)); same here. Also consider putting this part of some utils class. -- To view, visit http://gerrit.ovirt.org/2537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id78b33a9d7b96680b47fb833f4af3d73baed0c3c Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
