Mike Kolesnik has posted comments on this change. Change subject: DO NOT SUBMIT core: Adding new query ......................................................................
Patch Set 24: (4 inline comments) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQueryTest.java Line 92: /* Please delete the commented code Line 128: GetVmConfigurationBySnapshotQuery<GetVmConfigurationBySnapshotQueryParams> executeQuery = Why call executeQuery? Line 132: doReturn(existingVm).when(executeQuery).getVmFromConfiguration(anyString()); You can return this only for the snapshot manager call to get vm from config Line 146: return executeQuery; Why call executeQuery? -- To view, visit http://gerrit.ovirt.org/2295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3155134ff9ad89bb50ec4baa8fd393844f80bb32 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
