Maor Lipchuk has posted comments on this change. Change subject: engine-core: SyntaxCheckerFactory cleanup ......................................................................
Patch Set 1: Maybe initializing the checkers parameters when declaring them. By doing that you can get rid of a lot of code in the methods, and also not risk multiple instances. -- To view, visit http://gerrit.ovirt.org/2822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2b632c3c13f4ba4b6f5373b942b29198ce6853d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
