Allon Mureinik has posted comments on this change. Change subject: core: Cleanup VmDAODbFacadeImpl ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java Line 219: public static final VMRowMapper instance = new VMRowMapper(); No, as per http://ovirt.org/wiki/Backend_Coding_Standards. All the other DAOs use this convention. -- To view, visit http://gerrit.ovirt.org/2932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaa0c197c3b376aad96be110640f15b3fe6a7d17 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
