Allon Mureinik has posted comments on this change. Change subject: core: Remove unused fields from image tables ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (2 inline comments) Basically looks good, see some inline comments. Note that this review was on a java/database level. I grepped around to make sure these fields were indeed unused, and checked that the DAO tests pass, but I'd like smoeone who is more familiar with the feature to do a "business-logic" review. .................................................... File backend/manager/dbscripts/upgrade/03_01_0710_remove_unused_columns.sql Line 1: General comments: 1. please make the file name for specific. e.g., 03_01_0710_remove_unused_images_columns.sql 2. please use the common functions used for schema manipulation (e.g., fn_db_drop_column) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java Line 130: consider extracting the creation of the parameter source to a method instead of duplicating it in save(DiskImage) and update(DiskImage), while you're at it. Although I'm not sure this should be part of THIS patch. -- To view, visit http://gerrit.ovirt.org/3065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0878abf39fd36546d7ec86116ab8814a3db502bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
