Michael Kublin has posted comments on this change.
Change subject: engine: Create Gluster Volume & Volume Option Set
......................................................................
Patch Set 2: (11 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java
Line 41: protected boolean canDoAction() {
put those messages to protected void setActionMessageParameters() {}
Line 44:
I think that those check should at the end of the method, much more simple
checks should come before
Line 48:
use standard validation annotation on parameters like @NotNull
Line 67:
also should be validated during validateParameters() and not here, use
annotation
Line 73: if (volume.getVolumeType() == null) {
same here : anottation
Line 78: if (volume.getTransportType() == null) {
annotation
Line 103:
At case of failure executeVdsCommand an exception will be thrown.
No need for check here
Line 202: private void addVolumeToDb(final GlusterVolumeEntity
createdVolume) {
no need explicitly open transaction, only one save to DB, transaction will be
open automaticly
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
Line 68: */
no need for such method, something similar exists at CommandBase
Line 81: protected VdcReturnValueBase executeBllAction(VdcActionType
actionType, VdcActionParametersBase params) {
should be runActionInternal, will not acquire permissions check
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
Line 17: private static final long serialVersionUID = -7394070330293300587L;
please create a method which is retrieving a Dao, like getGlusterVolumeDao(),
similar to methods at CommandBase or AuditLogableBase
--
To view, visit http://gerrit.ovirt.org/3142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5a857d188450409ce9f6eefd4df6bc1b10f9b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
