Michael Kublin has posted comments on this change.
Change subject: core: Fix NPE when remove storage domain (#783083)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java
Line 76: if (dom == null) {
we already has appropriate error message for missing storage domain -
ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_EXIST, please remove a new added message,
also at any case when domain is removed, it means that at the execute we will
fail at host side, the check for null is ok, but solution is not full
--
To view, visit http://gerrit.ovirt.org/3221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59fba5ba715fb02fb69c48cfc79f20b17830fced
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
