Mike Kolesnik has posted comments on this change. Change subject: core : Locking - removed old code, introduced options for sahred and exclusive locks ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java Line 1095: LockIdNameAttribute annotation = getClass().getAnnotation(LockIdNameAttribute.class); Is this annotation really necessary in this case? Or do you just keep it as a marker annotation? .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromSnapshotParameters.java Line 35: @NotNull Here default message will be: javax.validation.constraints.NotNull.message What will be returned by looking for this resource string? I see that in most other places that this annotation is used, a custom message is specified. -- To view, visit http://gerrit.ovirt.org/3271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id358898597393ccd868127d8430cfb2bfbabafe0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
