Maor Lipchuk has submitted this change and it was merged. Change subject: core: Cleanup QuaotaDAOTest ......................................................................
core: Cleanup QuaotaDAOTest General java cleanup: 1. Proper use of JUnit features - don't call setUp directly, allow the frameowrk to call it. 2. Make private generator methods static when possible. 3. Avoid creating new instances of Long on each run. Change-Id: Iada674bd7ddc7a60f19e019158c2ab51649f4622 --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java 1 file changed, 9 insertions(+), 47 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iada674bd7ddc7a60f19e019158c2ab51649f4622 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
