Keith Robertson has posted comments on this change.
Change subject: tools: Make system and REST API rebase for log collector
......................................................................
Patch Set 4: (8 inline comments)
Fixed Ofer's comments in patch set 5.
....................................................
File Makefile
Line 49: tar --transform 's,^,/$(NAME_VER)/,S' -z -c -f $(TARBALL) `git
ls-files`
Seems like we're replacing a git dependency with an rsync one. I think I'll
leave it as is unless there is a major fuss over it.
Line 56: sed -i -e's/^Name:.*/Name: $(NAME)/' $(SPEC_FILE)
Nope. Fixed in next patch.
Line 60: rpmbuild -bs --define="_topdir $(RPMTOP)" --define="_sourcedir
." $(SPEC_FILE)
Fixed in next patch.
Line 81: rm -f $(PREFIX)/usr/bin/engine-log-collector
Removed.
....................................................
File ovirt-log-collector.spec.in
Line 4: Source: %{name}-%{version}.tar.gz
Fixed.
Line 28: %attr (755,root,root) %{_datadir}/ovirt-engine/log-collector
Done
....................................................
File src/rhev/engine-log-collector.8
Line 4: engine\-log\-collector \- oVirt Enterprise Virtualization Engine
Manager Log Collector
Done
....................................................
File src/sos/plugins/engine.py
Line 8: ("vdsmlogs", 'Directory containing all of the SOS logs from
the oVirt hypervisor(s)', '', False),
Done
--
To view, visit http://gerrit.ovirt.org/3212
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2648032f587118e2b0a5b3c194c4ba84390b37a2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
