Omer Frenkel has posted comments on this change.
Change subject: core: Check permission on Storage Domain when adding disk
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskToVmCommand.java
Line 206: VdcObjectType.Disk,
should be VOT.Storage
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1301: if (storagePool == null) {
i think handling null SP should not be part of this method
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
Line 37: List<PermissionSubject> permsList = null;
any reason to save it out of the method?
Line 295: }
need to change to copy/move on disk
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java
Line 72: public static Guid getGuidValue(NGuid id) {
you could do this in a single line
--
To view, visit http://gerrit.ovirt.org/3399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cc0d89e2a2a94ab103c9f373d038961231f13c3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
