Yair Zaslavsky has posted comments on this change.
Change subject: engine:Support for gluster asynchronous tasks
......................................................................
Patch Set 23: Code-Review+1
(1 comment)
Hi,
Only the issue on the comment, I'm treating it as if you don't really need
that, and giving you +1, but if you dont need the comment, remove it before
merge
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java
Line 57: }
Line 58:
Line 59: protected void handleTaskReturn(GlusterAsyncTask asyncTask) {
Line 60: Guid externalTaskId = asyncTask.getTaskId();
Line 61: //
getExecutionContext().getStep().setCorrelationId(externalTaskId.toString());
Real comment? todo? not clear... either remove this comment or mark as TODO or
something like that.
Line 62: asyncTaskStep.setStatus(JobExecutionStatus.STARTED);
Line 63: ExecutionHandler.updateStepExternalId(asyncTaskStep,
Line 64: externalTaskId,
Line 65: ExternalSystemType.GLUSTER);
--
To view, visit http://gerrit.ovirt.org/11840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a56785edef091bce74e2b7b0ba9a3314f1397f1
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
