Maor Lipchuk has posted comments on this change.
Change subject: engine: cleanup in RemoveSnapshotSingleDiskCommand
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
Line 48:
Line 49: return runVdsCommand(VDSCommandType.MergeSnapshots, params);
Line 50: }
Line 51:
Line 52: private Guid createTask(Guid taskId, VDSReturnValue
vdsReturnValue, Guid storageDomainId) {
It is a matter of style, but I would think to remove this method, it only act
as a proxy method to the super now after persistAsyncTaskPlaceHolder has been
removed
Line 53: String message =
ExecutionMessageDirector.resolveStepMessage(StepEnum.MERGE_SNAPSHOTS,
Line 54: getJobMessageProperties());
Line 55:
Line 56: return super.createTask(taskId,
vdsReturnValue.getCreationInfo(), VdcActionType.RemoveSnapshot,
--
To view, visit http://gerrit.ovirt.org/18688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe60ca192123553a2c5a2bac2f34b3e4d9a64f3b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
