Gilad Chaplik has posted comments on this change.

Change subject: webadmin: Restricted VNIC names to ASCII characters
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NoSpecialCharactersWithDotValidation.java
Line 5: 
Line 6: public class NoSpecialCharactersWithDotValidation extends 
RegexValidation {
Line 7: 
Line 8:     public NoSpecialCharactersWithDotValidation() {
Line 9:         setExpression(ValidationUtils.NO_SPECIAL_CHARACTERS_WITH_DOT);
just a thought, this is the first reference from the UI to ValidationUtils, 
maybe we should keep this separation? the frontend and backend handles regex 
differently.

what do you say?
Line 10:         
setMessage(ConstantsManager.getInstance().getConstants().noSpecialCharactersWithDotMsg());
Line 11:     }
Line 12: 


-- 
To view, visit http://gerrit.ovirt.org/18992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id85f0cec55ab073eff0a26acc884350d0977a1a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to