Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Show only supported displays
......................................................................
Patch Set 3:
(1 comment)
I think the logic to select the proper display protocol is missing from the
NewPoolModelBehavior.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
Line 334: }
Line 335: }
Line 336:
Line 337: @Override
Line 338: public void postDisplayTypeItemChanged() {
Consider the following scenario:
- select DC/Cluster and Template
- change the display protocol
- change the OS type
As a result, the display protocol gets reset to the template's one. I don't
think this is correct.
Maybe better would be calling this method only if the set of display types
changed AND the previously selected one is not a part of the newly available
ones. What do you think?
Line 339: VmTemplate template = (VmTemplate)
getModel().getTemplate().getSelectedItem();
Line 340:
Line 341: if (template != null)
Line 342: {
--
To view, visit http://gerrit.ovirt.org/17885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c91524181a7fa1fc2961c85df9bb78f553aa1ef
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
