Omer Frenkel has posted comments on this change.
Change subject: engine: nullify EmulatedMachine field only on cluster level
change
......................................................................
Patch Set 4:
(2 comments)
what about fixtures.xml for new field dao tests?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
Line 61: for (VDS vds : allForVdsGroup) {
Line 62: if (getVds().getStatus() == VDSStatus.Up) {
Line 63: emulatedMachine = ListUtils.firstMatch(
Line 64:
Config.<List<String>>GetValue(ConfigValues.ClusterEmulatedMachines,
Line 65:
vds.getVdsGroupCompatibilityVersion().getValue()),
vds.getSupportedEmulatedMachines().split(","));
just making sure you dont miss what tomas commented in the previous patch:
vds.getVdsGroupCompatibilityVersion() is the old cluster compatibility,
we need to use new compatibility ->
getParameters().getVdsGroup().getcompatibility_version()
Line 66: break;
Line 67: }
Line 68: }
Line 69: if (emulatedMachine == null) {
....................................................
File
packaging/dbscripts/upgrade/03_03_0830_add_detect_emulated_machine_to_cluster.sql
Line 1: SELECT fn_db_add_column('vds_groups', 'detect_emulated_machine',
'BOOLEAN');
what happens to existing clusters on upgrade?
--
To view, visit http://gerrit.ovirt.org/18898
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ffb180cfcd56c50b9bc228c0043e6fd5fee1c58
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
