Michael Pasternak has posted comments on this change. Change subject: restapi: add connections subresource for domain ......................................................................
Patch Set 1: Code-Review+1 (4 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-07-22 23:25:45 +0300 Line 4: Commit: Alissa Bonas <[email protected]> Line 5: CommitDate: 2013-09-10 11:17:45 +0300 Line 6: Line 7: restapi: add connections subresource for domain /s/domain/storagedomain Line 8: Line 9: Adding storage connections subresource for domains. Line 10: This subresource returns storage connections that Line 11: are in use by a specific domain. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStorageServerConnectionsForDomainQuery.java Line 1: package org.ovirt.engine.core.bll; Line 2: Line 3: import org.ovirt.engine.core.common.queries.IdQueryParameters; Line 4: Line 5: public class GetStorageServerConnectionsForDomainQuery<P extends IdQueryParameters> extends QueriesCommandBase<P> { i know this code was merged upstream already, but the name of the query is confusing, domain is ambiguous in the engine as it may stand for directory service or storage domain, i'd rename it. Line 6: Line 7: public GetStorageServerConnectionsForDomainQuery(P parameters) { Line 8: super(parameters); Line 9: } .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java Line 87: * Retrieves all connections used by the specified storage domain Line 88: * @param domainId Line 89: * @return the list of connections Line 90: */ Line 91: List<StorageServerConnections> getAllForDomain(Guid domainId); same comment, the name is ambiguous even in DAO Line 92: Line 93: /** Line 94: * Saves the specified connection. Line 95: * .................................................... File packaging/dbscripts/storages_sp.sql Line 688: END; $procedure$ Line 689: LANGUAGE plpgsql; Line 690: Line 691: Line 692: CREATE OR REPLACE FUNCTION GetStorageServerConnectionsForDomain(v_storage_domain_id UUID) same is true for SP, i'd call it: GetServerConnectionsForStorageDomain Line 693: RETURNS SETOF storage_server_connections Line 694: AS $procedure$ Line 695: BEGIN Line 696: RETURN QUERY SELECT * -- To view, visit http://gerrit.ovirt.org/19045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f63f8384c245eb28c18a3fde87ba57a8c1cd678 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
