Allon Mureinik has posted comments on this change.
Change subject: engine : VdsUpdateRuntimeInfo updates the data of a specific
VDS.
......................................................................
Patch Set 24: Code-Review+1
(2 comments)
Some minor nits inline (would be nice to fix, but shouldn't block the patch)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAO.java
Line 63: * @return <code>true</true> if at least one row was updated,
<code>false</code>
Line 64: * otherwise
Line 65: */
Line 66: boolean updateConsoleUserWithOptimisticLocking(VmDynamic vm);
Line 67:
Looks like redundant noise in this patch, please remove it when you rebase.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java
Line 186: interfaceDAO.removeStatisticsForVds(dbIface.getId());
Line 187: }
Line 188: }
Line 189:
Line 190: if (dbIfacesToBatch.size() > 0) {
I'd use "if (!dbIfacesToBatch.isEmpty()) {" - seems clearer.
Line 191: interfaceDAO.massUpdateInterfacesForVds(dbIfacesToBatch);
Line 192: }
Line 193:
Line 194: // now all that left is add the interfaces that not exists in
the Database
--
To view, visit http://gerrit.ovirt.org/16066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3e9735f4174ebabbe293d397d931aba72bbbd7b
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
