Yair Zaslavsky has posted comments on this change.
Change subject: gluster: Gluster volume rebalance status entities
......................................................................
Patch Set 24: Code-Review+1
(2 comments)
Minor comments
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTaskStatus.java
Line 10: STARTED("STARTED"),
Line 11: STOPPED("STOPPED"),
Line 12: FAILED("FAILED"),
Line 13: UNKNOWN("UNKNOWN"),
Line 14: NOT_STARTED("NOT STARTED"), ;
Please remove the extra ","
Line 15:
Line 16: private String statusMsg;
Line 17:
Line 18: private GlusterAsyncTaskStatus(String status) {
Line 19: statusMsg = status;
Line 20: }
Line 21:
Line 22: public String value() {
Line 23: return statusMsg.toUpperCase();
but it's already defined as upper case - so, do we really need to run
"toUpperCase"?
Line 24: }
Line 25:
Line 26: public static GlusterAsyncTaskStatus from(String status) {
Line 27: for (GlusterAsyncTaskStatus taskStatus : values()) {
--
To view, visit http://gerrit.ovirt.org/18297
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c118790c57bf6d3ed0324a6f2a965783de2c57
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
