Arik Hadas has uploaded a new change for review. Change subject: core: lock VM for whole live snapshot process ......................................................................
core: lock VM for whole live snapshot process VM was used to be locked for the entire live snapshot process only in case the snapshot contained memory. If the snapshot did not contain memory, the lock was released in the execute state of the command. This patch changes that, such that the VM will be locked for the entire live snapshot process in any case. Change-Id: Ib455a3b27d7b032c6a706753a6e58e07d3a1bc14 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/62/19162/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java index e45cff8..cb5846c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java @@ -67,8 +67,6 @@ private List<DiskImage> cachedSelectedActiveDisks; private Guid cachedStorageDomainId = Guid.Empty; - /** flag that indicates whether memory snapshot is about to be created */ - private boolean prepareForMemorySnapshot; private String cachedSnapshotIsBeingTakenMessage; private Guid newActiveSnapshotId = Guid.newGuid(); @@ -138,10 +136,6 @@ incrementVmGeneration(); } - if (!prepareForMemorySnapshot) { - freeLock(); - } - setSucceeded(true); } @@ -166,7 +160,6 @@ } if (getParameters().isSaveMemory() && isLiveSnapshotApplicable()) { - prepareForMemorySnapshot = true; return new LiveSnapshotMemoryImageBuilder(getVm(), getStorageDomainIdForVmMemory(), getStoragePool(), this); } -- To view, visit http://gerrit.ovirt.org/19162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib455a3b27d7b032c6a706753a6e58e07d3a1bc14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
