Frank Kobzik has posted comments on this change.
Change subject: engine: Cache spice support for os/compatibility version
......................................................................
Patch Set 2:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java
Line 35: break;
Line 36: case GetMinimumOsRam:
Line 37:
setReturnValue(osRepository.getMinimumRam(getParameters().getOsId(),
getParameters().getVersion()));
Line 38: break;
Line 39: case HasSpiceSupportMatrix:
Done
Line 40: setReturnValue(osRepository.spiceSupportMatrix());
Line 41: break;
Line 42: case GetNetworkDevices:
Line 43:
setReturnValue(osRepository.getNetworkDevices(getParameters().getOsId(),
getParameters().getVersion()));
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
Line 68: /**
Line 69: * @return map (osId -> compatibility version -> true/false) that
indicates SPICE support for all OSs and
Line 70: * compatibility versions
Line 71: */
Line 72: public Map<Integer, Map<Version, Boolean>> spiceSupportMatrix();
Done.
Hmm, it compiles and runs without any problems. Is there anything to be worried
about? :)
Line 73:
Line 74: /**
Line 75: * this is Windows OSs specific path to the sysprep file
Line 76: * @param osId
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java
Line 151:
Line 152: for (Integer osId : getOsIds()) {
Line 153: spiceSupportMatrix.put(osId, new HashMap<Version,
Boolean>());
Line 154:
Line 155: Set<Version> versions = new HashSet<Version>(Version.ALL);
Done
Line 156: versions.add(null);
Line 157:
Line 158: for (Version ver : versions) {
Line 159: boolean spiceSupport =
getBoolean(getValueByVersion(idToUnameLookup.get(osId), "spiceSupport", ver),
false);
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java
Line 73:
Line 74: final boolean isWindowsExplorer =
parentModel.getConfigurator().isClientWindowsExplorer();
Line 75:
Line 76: Boolean hasSpiceSupport =
AsyncDataProvider.hasSpiceSupport(vm.getOs(),
vm.getVdsGroupCompatibilityVersion());
Line 77: if (isWindowsExplorer && hasSpiceSupport != null &&
hasSpiceSupport.booleanValue()) {
Done
Line 78: cachedModels.get(RDP_INDEX).setUserSelected(true);
Line 79: } else {
Line 80: determineConsoleModelFromVm(vm,
cachedModels).setUserSelected(true);
Line 81: }
--
To view, visit http://gerrit.ovirt.org/19137
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib97d68ccd0d30fd07e8d1a7d1322f731aef220f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
