Ramesh N has posted comments on this change.
Change subject: engine:VDS Command for Start Gluster volume remove brick
......................................................................
Patch Set 4:
(2 comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CommitRemoveGlusterVolumeBricksVDSCommand.java
Line 10:
Line 11: @Override
Line 12: protected void ExecuteVdsBrokerCommand() {
Line 13: status =
getBroker().glusterVolumeRemoveBricksCommit(getParameters().getVolumeName(),
Line 14: getParameters().getBrickDirectories().toArray(new
String[0]),
VDSM accepts these parameters. Need check again without passing these values
Line 15: getParameters().getReplicaCount());
Line 16:
Line 17: proceedProxyReturnValue();
Line 18: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
Line 214: int replicCount);
Line 215:
Line 216: StatusOnlyReturnForXmlRpc glusterVolumeRemoveBricksCommit(String
volumeName,
Line 217: String[] brickList,
Line 218: int replicCount);
VDSM accepts these parameter. Need to check without passing this parameter
Line 219:
Line 220: StatusOnlyReturnForXmlRpc glusterVolumeBrickAdd(String volumeName,
Line 221: String[] bricks,
Line 222: int replicaCount,
--
To view, visit http://gerrit.ovirt.org/18881
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a4d829c43a209b51d14c952bac1ada77e40083b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
