Ramesh N has posted comments on this change.
Change subject: engine:BLL Command to Start Remove Gluster volume brick
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRemoveGlusterVolumeBricksCommand.java
Line 112: * @param bricks
Line 113: * The bricks to validate
Line 114: * @return true if all bricks have valid ids, else false
Line 115: */
Line 116: private boolean validateBricks(List<GlusterBrickEntity> bricks) {
Moved this validation to a separate validator class. GLusterBrickValidator.java
Line 117: GlusterVolumeEntity volume = getGlusterVolume();
Line 118: for (GlusterBrickEntity brick : bricks) {
Line 119: if (brick.getServerName() != null &&
brick.getBrickDirectory() != null) {
Line 120: // brick already contains required info.
--
To view, visit http://gerrit.ovirt.org/18923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ee4620b75b4b714087dbf1dec3720661a5ce6b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
