Allon Mureinik has posted comments on this change.
Change subject: engine: Illegal images should be skipped when validating
duplicates
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
Line 365: }
Line 366: return true;
Line 367: }
Line 368:
Line 369: protected boolean
validateNoDuplicateDiskImages(Iterable<DiskImage> diskImages) {
note you have two whitespaces here
Line 370: List<String> existingLegalDisksAliases = new
ArrayList<String>();
Line 371: List<DiskImage> duplicateDiskImages =
getDuplicateDiskImagesFromDB(diskImages);
Line 372:
Line 373: if (duplicateDiskImages.isEmpty()) {
Line 388: getParameters().setForceOverride(true);
Line 389: return true;
Line 390: }
Line 391:
Line 392: private List<DiskImage>
getDuplicateDiskImagesFromDB(Iterable<DiskImage> images) {
consider renaming this (e.g., getDisksFromDB) and moving to ImagesHandler.
Line 393: List<DiskImage> duplicateImages = new ArrayList<>();
Line 394: for (DiskImage image : images) {
Line 395: DiskImage diskImage =
getDiskImageDao().get(image.getId());
Line 396: if (diskImage != null) {
--
To view, visit http://gerrit.ovirt.org/19246
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b43e4b4e8e04dfb644a33ea9ce2a474987c5e3c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
