Omer Frenkel has posted comments on this change.
Change subject: core: LocalAdminPassword exception after engine restart
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
Line 218: @Override
Line 219: public <T> T getValue(ConfigValues name, String version) {
Line 220: T returnValue;
Line 221: Map<String, Object> values = null;
Line 222: if ((values = _vdcOptionCache.get(name.toString())) != null
&& (values.containsKey(version) || values.containsKey("general"))) {
sorry i dont understand this solution, from this fix it looks like the error is
in the usage, as caller should have sent "general" in the version, and this
hack wouldn't be needed, no?
Line 223: returnValue = (T) values.get(version);
Line 224: } else {
Line 225: VdcOption option = new VdcOption();
Line 226: option.setoption_name(name.toString());
--
To view, visit http://gerrit.ovirt.org/18065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I000bbb3cf5a6d1d636c49247e85858b02b2f358a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
