Allon Mureinik has posted comments on this change.
Change subject: core: move unplugged disks while VM is running
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
Line 208: private boolean isAllDisksUnplugged(List<MoveDiskParameters>
moveDiskParamsList) {
Line 209: return isAllDisksPlugged(moveDiskParamsList, false);
Line 210: }
Line 211:
Line 212: private boolean isAllDisksPlugged(List<MoveDiskParameters>
moveDiskParamsList, boolean plugged) {
please find a better name for this.
Line 213: for (MoveDiskParameters moveDiskParameters :
moveDiskParamsList) {
Line 214: DiskImage diskImage =
diskMap.get(moveDiskParameters.getImageId());
Line 215: if (diskImage.getPlugged() != plugged) {
Line 216: return false;
--
To view, visit http://gerrit.ovirt.org/19105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0fbfd95c0086cfe0d792b3071a2d804ff32c18e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
