Allon Mureinik has posted comments on this change.
Change subject: engine: StorageVersionUtil fixes
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java
Line 35: }
Line 36:
Line 37: private static class V2FormatTypeMapper implements
StorageFormatTypeMapper {
Line 38: @Override
Line 39: public StorageFormatType getPreferred(StorageType t) {
Done
Line 40: if (t.isBlockDomain()) {
Line 41: return StorageFormatType.V2;
Line 42: }
Line 43: return StorageFormatType.V1;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
Line 616: .changeDataCenterCompatibilityVersionTitle());
Line 617:
confirmModel.setHashName("change_data_center_compatibility_version");
//$NON-NLS-1$
Line 618:
Line 619: StoragePool sp = (StoragePool) getSelectedItem();
Line 620: StorageFormatType newFormat =
VersionStorageFormatUtil.getPreferredForVersion((Version)
model.getVersion().getSelectedItem(), sp.getStorageType());
Done
Line 621: StorageFormatType oldFormat =
VersionStorageFormatUtil.getPreferredForVersion(sp.getcompatibility_version(),
sp.getStorageType());
Line 622: if (newFormat == oldFormat) {
Line 623: confirmModel.setMessage(ConstantsManager.getInstance()
Line 624: .getConstants()
--
To view, visit http://gerrit.ovirt.org/19193
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf7eb690f343b1cf8007a9d8b30a3ce22a6a57dc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
