Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: fix QoS dialog indentation ......................................................................
webadmin: fix QoS dialog indentation Labels will be positions above the fields, instead of next to it. Also fixed unnecessary dialog scroll bars Change-Id: Ifbcfa6849284d2e087c6884aa79cd77d9f4c3096 Bug-Url: https://bugzilla.redhat.com/1001546 Signed-off-by: Gilad Chaplik <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.ui.xml 2 files changed, 35 insertions(+), 39 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/19356/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java index 6047b30..435be6b 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java @@ -1,13 +1,6 @@ package org.ovirt.engine.ui.webadmin.section.main.view.popup.networkQoS; -import com.google.gwt.core.client.GWT; -import com.google.gwt.editor.client.SimpleBeanEditorDriver; -import com.google.gwt.event.shared.EventBus; -import com.google.gwt.resources.client.CssResource; -import com.google.gwt.uibinder.client.UiBinder; -import com.google.gwt.uibinder.client.UiField; -import com.google.inject.Inject; import org.ovirt.engine.core.common.businessentities.StoragePool; import org.ovirt.engine.ui.common.idhandler.ElementIdHandler; import org.ovirt.engine.ui.common.idhandler.WithElementId; @@ -22,6 +15,14 @@ import org.ovirt.engine.ui.webadmin.ApplicationConstants; import org.ovirt.engine.ui.webadmin.ApplicationResources; import org.ovirt.engine.ui.webadmin.section.main.presenter.popup.NetworkQoSPopupPresenterWidget; + +import com.google.gwt.core.client.GWT; +import com.google.gwt.editor.client.SimpleBeanEditorDriver; +import com.google.gwt.event.shared.EventBus; +import com.google.gwt.resources.client.CssResource; +import com.google.gwt.uibinder.client.UiBinder; +import com.google.gwt.uibinder.client.UiField; +import com.google.inject.Inject; public class NetworkQoSPopupView extends AbstractModelBoundPopupView<NetworkQoSModel> @@ -108,12 +109,12 @@ localize(constants); driver.initialize(this); - inboundAverageEditor.asValueBox().getParent().setStyleName(style.valuePanelWidth()); - inboundPeakEditor.asValueBox().getParent().setStyleName(style.valuePanelWidth()); - inboundBurstEditor.asValueBox().getParent().setStyleName(style.valuePanelWidth()); - outboundAverageEditor.asValueBox().getParent().setStyleName(style.valuePanelWidth()); - outboundPeakEditor.asValueBox().getParent().setStyleName(style.valuePanelWidth()); - outboundBurstEditor.asValueBox().getParent().setStyleName(style.valuePanelWidth()); + inboundAverageEditor.setContentWidgetStyleName(style.valueWidth()); + inboundPeakEditor.setContentWidgetStyleName(style.valueWidth()); + inboundBurstEditor.setContentWidgetStyleName(style.valueWidth()); + outboundAverageEditor.setContentWidgetStyleName(style.valueWidth()); + outboundPeakEditor.setContentWidgetStyleName(style.valueWidth()); + outboundBurstEditor.setContentWidgetStyleName(style.valueWidth()); } private void initListBoxEditors() { @@ -158,6 +159,6 @@ interface WidgetStyle extends CssResource { - String valuePanelWidth(); + String valueWidth(); } } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.ui.xml b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.ui.xml index ed9fc91..0238d26 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.ui.xml +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.ui.xml @@ -9,66 +9,61 @@ <ui:style type="org.ovirt.engine.ui.webadmin.section.main.view.popup.networkQoS.NetworkQoSPopupView.WidgetStyle"> .topDecorator { background-color: #D3D3D3; - margin-bottom: 8px; - margin-top: 4px; - margin-right: 3px; - padding-top: 6px; - padding-bottom: 6px; + margin: 5px; } .labelStyle { font-weight: bold; + width: 90%; padding-left: 5px; - margin-top: 30px; } .mbpsLabel { text-align: right; font-size: smaller; color: gray; } - .valuePanelWidth { - width: 65px; - float: right; + .valueWidth { + width: 110px; + padding-left: 5px; } - .marginLeft { - margin-left: 40px; + .valuePanelStyle { + padding-left: 30px; } - </ui:style> <d:SimpleDialogPanel width="500px" height="400px"> <d:content> - <g:FlowPanel> + <g:FlowPanel> <g:FlowPanel addStyleNames="{style.topDecorator}"> <e:ListModelListBoxEditor ui:field="dataCenterEditor" /> <e:EntityModelTextBoxEditor ui:field="nameEditor" /> </g:FlowPanel> <e:EntityModelCheckBoxEditor addStyleNames="{style.labelStyle}" ui:field="inboundEnabled"/> <g:HorizontalPanel> - <g:VerticalPanel> - <e:EntityModelTextBoxEditor addStyleNames="{style.marginLeft}" ui:field="inboundAverageEditor" /> + <g:VerticalPanel addStyleNames="{style.valuePanelStyle}"> + <e:EntityModelTextBoxEditor ui:field="inboundAverageEditor" /> <g:Label addStyleNames="{style.mbpsLabel}" text="{constants.mbpsLabelQoSPopup}"/> </g:VerticalPanel> - <g:VerticalPanel> - <e:EntityModelTextBoxEditor addStyleNames="{style.marginLeft}" ui:field="inboundPeakEditor" /> + <g:VerticalPanel addStyleNames="{style.valuePanelStyle}"> + <e:EntityModelTextBoxEditor ui:field="inboundPeakEditor" /> <g:Label addStyleNames="{style.mbpsLabel}" text="{constants.mbpsLabelQoSPopup}"/> </g:VerticalPanel> - <g:VerticalPanel> - <e:EntityModelTextBoxEditor addStyleNames="{style.marginLeft}" ui:field="inboundBurstEditor" /> + <g:VerticalPanel addStyleNames="{style.valuePanelStyle}"> + <e:EntityModelTextBoxEditor ui:field="inboundBurstEditor" /> <g:Label addStyleNames="{style.mbpsLabel}" text="{constants.mbLabelQoSPopup}"/> </g:VerticalPanel> </g:HorizontalPanel> <e:EntityModelCheckBoxEditor addStyleNames="{style.labelStyle}" ui:field="outboundEnabled"/> <g:HorizontalPanel> - <g:VerticalPanel> - <e:EntityModelTextBoxEditor addStyleNames="{style.marginLeft}" ui:field="outboundAverageEditor" /> + <g:VerticalPanel addStyleNames="{style.valuePanelStyle}"> + <e:EntityModelTextBoxEditor ui:field="outboundAverageEditor" /> <g:Label addStyleNames="{style.mbpsLabel}" text="{constants.mbpsLabelQoSPopup}"/> </g:VerticalPanel> - <g:VerticalPanel> - <e:EntityModelTextBoxEditor addStyleNames="{style.marginLeft}" ui:field="outboundPeakEditor" /> + <g:VerticalPanel addStyleNames="{style.valuePanelStyle}"> + <e:EntityModelTextBoxEditor ui:field="outboundPeakEditor" /> <g:Label addStyleNames="{style.mbpsLabel}" text="{constants.mbpsLabelQoSPopup}"/> </g:VerticalPanel> - <g:VerticalPanel> - <e:EntityModelTextBoxEditor addStyleNames="{style.marginLeft}" ui:field="outboundBurstEditor" /> + <g:VerticalPanel addStyleNames="{style.valuePanelStyle}"> + <e:EntityModelTextBoxEditor ui:field="outboundBurstEditor" /> <g:Label addStyleNames="{style.mbpsLabel}" text="{constants.mbLabelQoSPopup}"/> </g:VerticalPanel> </g:HorizontalPanel> -- To view, visit http://gerrit.ovirt.org/19356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifbcfa6849284d2e087c6884aa79cd77d9f4c3096 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
