Alissa Bonas has uploaded a new change for review. Change subject: core: rename methods to lowercase in storage commands ......................................................................
core: rename methods to lowercase in storage commands Change-Id: Ic90230c11cf11fe510c803c69ffa2bac0b0c2982 Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DisconnectStorageServerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java 3 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/19139/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java index 4ed9383..56b9056 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java @@ -30,7 +30,7 @@ @Override protected void executeVdsBrokerCommand() { _result = getBroker().connectStorageServer(getParameters().getStorageType().getValue(), - getParameters().getStoragePoolId().toString(), BuildStructFromConnectionListObject()); + getParameters().getStoragePoolId().toString(), buildStructFromConnectionListObject()); proceedProxyReturnValue(); Map<String, String> returnValue = _result.convertToStatusList(); setReturnValue(returnValue); @@ -55,20 +55,20 @@ } @SuppressWarnings("unchecked") - protected Map<String, String>[] BuildStructFromConnectionListObject() { + protected Map<String, String>[] buildStructFromConnectionListObject() { final StoragePool storagePool = DbFacade.getInstance().getStoragePoolDao().getForVds(getParameters().getVdsId()); final Map<String, String>[] result = new HashMap[getParameters().getConnectionList().size()]; int i = 0; for (StorageServerConnections connection : getParameters().getConnectionList()) { - result[i] = CreateStructFromConnection(connection, storagePool); + result[i] = createStructFromConnection(connection, storagePool); i++; } return result; } - public static Map<String, String> CreateStructFromConnection(final StorageServerConnections connection, - final StoragePool storagePool) { + public static Map<String, String> createStructFromConnection(final StorageServerConnections connection, + final StoragePool storagePool) { // for information, see _connectionDict2ConnectionInfo in vdsm/storage/hsm.py DefaultValueMap con = new DefaultValueMap(); con.put("id", connection.getid(), Guid.Empty.toString()); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DisconnectStorageServerVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DisconnectStorageServerVDSCommand.java index 75d8167..949fd68 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DisconnectStorageServerVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DisconnectStorageServerVDSCommand.java @@ -11,7 +11,7 @@ @Override protected void executeVdsBrokerCommand() { _result = getBroker().disconnectStorageServer(getParameters().getStorageType().getValue(), - getParameters().getStoragePoolId().toString(), BuildStructFromConnectionListObject()); + getParameters().getStoragePoolId().toString(), buildStructFromConnectionListObject()); proceedProxyReturnValue(); setReturnValue(_result.convertToStatusList()); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java index 256c6cc..faf0c76 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java @@ -17,7 +17,7 @@ @Override protected void executeVdsBrokerCommand() { _result = getBroker().discoverSendTargets( - ConnectStorageServerVDSCommand.CreateStructFromConnection(getParameters().getConnection(),null)); + ConnectStorageServerVDSCommand.createStructFromConnection(getParameters().getConnection(), null)); proceedProxyReturnValue(); setReturnValue(_result.isFullTargets() ? parseFullTargets(_result.getIqnList()) : parseTargets(_result.getIqnList())); -- To view, visit http://gerrit.ovirt.org/19139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic90230c11cf11fe510c803c69ffa2bac0b0c2982 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
