Ayal Baron has posted comments on this change.
Change subject: engine: Engine has to delete image from DB after VDSM removed it
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 94: }
Line 95: // in case of any error other than
ImageDoesNotExistInDomainError, Engine has to check
Line 96: // if the image still exists on the storage, because
VDSM renames the image before deleting it,
Line 97: // so technically the image doesn't exist after
renaming but the actual delete can still fail.
Line 98: else if (isImageRemovedFromStorage()) {
why would performImageDbOperations succeed if performImageVdsmOperation failed
yet isImageRemovedFromStorage is true?
also if GetImagesList fails then you again reach the same end result.
As we discussed, I think the first part should be just being able to live with
the situation (automatically overwriting or whatever) and only afterwards
trying to reduce these situations
Line 99: log.infoFormat("The image group with id {0} was
deleted from storage");
Line 100: } else {
Line 101: throw e;
Line 102: }
--
To view, visit http://gerrit.ovirt.org/19161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6e6922b153145de6d4515812c1cfede687544bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
