Allon Mureinik has posted comments on this change. Change subject: core: permission filtering for GetStorageDomainsByVmTemplateId ......................................................................
Patch Set 2: (3 inline comments) 1. Please add unit tests, at least for the DAO code, preferably to the queries too. 2. See inline comments .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByVmTemplateIdQuery.java Line 24: ArrayList<storage_domains> result = new ArrayList<storage_domains>(); This call should be filtered for permissions. Line 36: By definition, if a user has permissions for a template with disk on a storage pool, doesn't he have permissions to see that storage pool? .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java Line 63: Use the static StorageDoaminRowMapper.instance, as per http://ovirt.org/wiki/Backend_Coding_Standards -- To view, visit http://gerrit.ovirt.org/2966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I136016e5b2a28c5a0ee4c1ba87b0f1c312db7241 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
