Allon Mureinik has posted comments on this change. Change subject: core: Permission filtering for GetVmTemplatesFromStorageDomain ......................................................................
Patch Set 2: (1 inline comment) Basically looks good (but note a minor inline comment), besides the lack of tests. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java Line 47: @Override Please stay consistent with getAllForStorageDomain(Guid storageDomain) - replace "id" with "storageDoamin" -- To view, visit http://gerrit.ovirt.org/1903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88fa3a942008621297c22a4bbdf715e50255aaa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
