Sandro Bonazzola has uploaded a new change for review. Change subject: packaging: setup: check existing storage pools ......................................................................
packaging: setup: check existing storage pools Check if there is already a storage pool connected and fail if it exists. Change-Id: Id58e2cce9f0e8d4e69590e006f1b2b72996ebd2f Signed-off-by: Sandro Bonazzola <[email protected]> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 22 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-setup refs/changes/09/19209/1 diff --git a/src/plugins/ovirt-hosted-engine-setup/storage/storage.py b/src/plugins/ovirt-hosted-engine-setup/storage/storage.py index 733ba9e..1e7bf86 100644 --- a/src/plugins/ovirt-hosted-engine-setup/storage/storage.py +++ b/src/plugins/ovirt-hosted-engine-setup/storage/storage.py @@ -463,6 +463,26 @@ self.logger.debug(info) self.logger.debug(self.serv.s.repoStats()) + def _check_existing_pools(self): + self.logger.debug('_check_existing_pools') + self.logger.debug('getConnectedStoragePoolsList') + pools = self.serv.s.getConnectedStoragePoolsList() + self.logger.debug(pools) + if pools['status']['code'] != 0: + raise RuntimeError(pools['status']['message']) + if pools['poollist']: + self.logger.error( + _( + 'The following storage pool has been found connected: ' + '{pools}' + ).format( + pools=', '.join(pools['poollist']) + ) + ) + raise RuntimeError( + _('Cannot setup Hosted Engine with connected storage pools') + ) + @plugin.event( stage=plugin.Stages.STAGE_INIT, ) @@ -539,6 +559,7 @@ ) ) self.serv = self.environment[ohostedcons.VDSMEnv.VDS_CLI] + self._check_existing_pools() interactive = ( self.environment[ ohostedcons.StorageEnv.STORAGE_DOMAIN_CONNECTION @@ -656,7 +677,7 @@ def _misc(self): self.waiter = tasks.TaskWaiter(self.environment) self.serv = self.environment[ohostedcons.VDSMEnv.VDS_CLI] - + self._check_existing_pools() # vdsmd has been restarted, we need to reconnect in any case. self._storageServerConnection() if self.domain_exists: -- To view, visit http://gerrit.ovirt.org/19209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id58e2cce9f0e8d4e69590e006f1b2b72996ebd2f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
