Ayal Baron has posted comments on this change.
Change subject: frontend: display correct format in edit domain
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
Line 674: }
Line 675: }
Line 676:
Line 677: getFormat().setItems(formats);
Line 678: getFormat().setSelectedItem(getStorage() != null ?
getStorage().getStorageFormat() : selectItem);
I did not explain properly.
I think there is a bug here (unless I'm missing something).
Iiuc, when we reach this state (which is what we're trying to solve in the bug)
then formats contains *only* V2, but setSelectedItem will try to set it to V1
and should throw an exception or something on trying to select an item which
does not exist in the list
Line 679: }
Line 680:
Line 681: private void updateItemsAvailability()
Line 682: {
--
To view, visit http://gerrit.ovirt.org/19187
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0432d633fabcf62b14b267b8dd9ca517b69c029a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
