Michael Kublin has posted comments on this change.
Change subject: engine-core: add plug/unplug VM nic command
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugUnplugVmNicCommand.java
Line 21: private VmDevice vmDevice;
Make getter at parent class it is better, also we don't need internal variable
which is points on singelton
Line 37: if (vmDevice == null) {
should be returnValue && vmDevice == null
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/PlugAction.java
Line 4:
It is boolean, why we need additional enum which points on two value, boolean
is enought
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
Line 127
why removed comment?
--
To view, visit http://gerrit.ovirt.org/3204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17897c18eccae41954e01b264fa74427e0bce1a2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
