Kanagaraj M has posted comments on this change.
Change subject: webadmin: gluster volume rebalance status popup
......................................................................
Patch Set 28:
(5 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
Line 282: <include name="common/action/gluster/*.java"/>
Line 283: <include name="common/queries/gluster/*.java"/>
Line 284: <include
name="common/constants/gluster/GlusterConstants.java"/>
Line 285: <include
name="common/utils/gluster/GlusterCoreUtil.java"/>
Line 286: <include name="common/utils/gluster/SizeConverter.java"/>
Please fix the indentation
Line 287:
Line 288: <!-- Scheduling -->
Line 289: <include name="common/scheduling/*.java"/>
Line 290: <include name="common/scheduling/parameters/*.java"/>
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeRebalanceStatusModel.java
Line 35: private ListModel rebalanceSessions;
Line 36:
Line 37: private boolean isStatusAvailable;
Line 38:
Line 39: private GlusterVolumeEntity volumeEntity;
GlusterVolumeEntity is repeated, remove it if not required
Line 40:
Line 41: public VolumeRebalanceStatusModel(final GlusterVolumeEntity
volumeEntity) {
Line 42: setStatus(new EntityModel());
Line 43: setVolume(new EntityModel());
Line 131: AsyncDataProvider.getGlusterRebalanceStatus(new
AsyncQuery(this, new INewAsyncCallback() {
Line 132:
Line 133: @Override
Line 134: public void onSuccess(Object model, Object returnValue) {
Line 135: // TODO Auto-generated method stub
Remove all TODOs in this file
Line 136: GlusterVolumeTaskStatusEntity rebalanceEntity =
(GlusterVolumeTaskStatusEntity) returnValue;
Line 137: showStatus(rebalanceEntity);
Line 138: }
Line 139: }), volumeEntity.getClusterId(), volumeEntity.getId());
Line 160:
Line 161: public void setStatusAvailable(boolean isStatusAvailable) {
Line 162: this.isStatusAvailable = isStatusAvailable;
Line 163: if(isStatusAvailable == true) {
Line 164: onPropertyChanged(new
PropertyChangedEventArgs("STATUS_LABEL_IS_VALID"));//$NON-NLS-1$
"IS_STATUS_AVAILABLE" could be more appropriate.
Line 165: }else {
Line 166: onPropertyChanged(new
PropertyChangedEventArgs("STATUS_LABEL_IS_NOT_VALID"));//$NON-NLS-1$
Line 167: }
Line 168: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 102:
Line 103: public UICommand getStatusRebalanceCommand() {
Line 104: return statusRebalanceCommand;
Line 105: }
Line 106:
why stop is changed to status?
Line 107: public void setStatusRebalanceCommand(UICommand
statusRebalanceCommand) {
Line 108: this.statusRebalanceCommand = statusRebalanceCommand;
Line 109: }
Line 110:
--
To view, visit http://gerrit.ovirt.org/18328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1f63b21dfbed88fa2b4e8c077e3e5e54ba7b09
Gerrit-PatchSet: 28
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
