Alexander Wels has posted comments on this change.
Change subject: webadmin: Host interface manual refresh
......................................................................
Patch Set 2:
(5 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java
Line 139: public void onClick(ClickEvent event) {
Line 140: if (manualRefreshCallback != null) {
Line 141: manualRefreshCallback.onManualRefresh();
Line 142: }
Line 143: ManualRefreshEvent.fire(manager);
Done
Line 144: controller.refresh();
Line 145: }
Line 146: });
Line 147: }
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/ManualRefreshEvent.java
Line 5: import com.google.gwt.event.shared.EventHandler;
Line 6: import com.google.gwt.event.shared.GwtEvent;
Line 7: import com.google.gwt.event.shared.HasHandlers;
Line 8:
Line 9: public class ManualRefreshEvent extends GwtEvent<ManualRefreshHandler> {
Done
Line 10: /**
Line 11: * Manual refresh handler type.
Line 12: */
Line 13: private static final Type<ManualRefreshHandler> TYPE = new
Type<ManualRefreshHandler>();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java
Line 62: }
Line 63:
Line 64: @ProxyEvent
Line 65: @Override
Line 66: public void onManualRefresh(ManualRefreshEvent event) {
Done
Won't the other @ProxyEvent already have the same effect?
Line 67: getView().removeContent();
Line 68: }
Line 63:
Line 64: @ProxyEvent
Line 65: @Override
Line 66: public void onManualRefresh(ManualRefreshEvent event) {
Line 67: getView().removeContent();
Done
Line 68: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
Line 28: import com.google.gwt.user.client.ui.VerticalPanel;
Line 29:
Line 30: public class SubTabHostInterfaceView extends
AbstractSubTabFormView<VDS, HostListModel, HostInterfaceListModel>
Line 31: implements SubTabHostInterfacePresenter.ViewDef {
Line 32: HostInterfaceForm hostInterfaceForm = null;
Done
Line 33:
Line 34: interface ViewIdHandler extends
ElementIdHandler<SubTabHostInterfaceView> {
Line 35: ViewIdHandler idHandler = GWT.create(ViewIdHandler.class);
Line 36: }
--
To view, visit http://gerrit.ovirt.org/19143
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e38c077a6eeef335fe1f8e8f468c70a5ca8ad92
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
