Sahina Bose has posted comments on this change.

Change subject: restapi: Modified gluster volume rebalance action
......................................................................


Patch Set 6:

(2 comments)

....................................................
Commit Message
Line 6: 
Line 7: restapi: Modified gluster volume rebalance action
Line 8: 
Line 9: Modified the gluster volume rebalance api.
Line 10: There was no Task Id field in the front-end entity class.
Task Is or Task entity? Rebalance should return task entity so that it can be 
monitored via Step id. Please update commit message to reflect this
Line 11: Introduced the same so that REST output gets the Task Id
Line 12: as well while firing the rebalance action. This Task Id could be used
Line 13: for further status monitoring of the task.
Line 14: 


....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 3680:       </xs:extension>
Line 3681:     </xs:complexContent>
Line 3682:   </xs:complexType>
Line 3683: 
Line 3684: <xs:element name="tasks" type="GlusterTasks"/>
do we really need this?
Line 3685: <xs:complexType name="GlusterTasks">
Line 3686:     <xs:complexContent>
Line 3687:       <xs:extension base="BaseResources">
Line 3688:         <xs:sequence>


-- 
To view, visit http://gerrit.ovirt.org/18208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9fd560cc1b6a0db9cc28647bc311cb9f1b9e3b3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to