Einav Cohen has posted comments on this change. Change subject: UI: expose CSS class defined in LoginPopupView.ui.xml ......................................................................
Patch Set 4: I am not sure that I am comfortable with this patch - I gave a comment on Aug 28 (on patch set 4) which the patch author acknowledged (see comment after that), however no updated patch set(s) were sent since. @Alexander/lijing - can you please change the commit comment to detail the styles that are being externalized in this patch? @Alexander: does it make sense for all of the styles being externalized here to be externalized? -- To view, visit http://gerrit.ovirt.org/18156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80dcacf8d62f9bb051747e530f0d24e692388ce7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: 静 黎 <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: 静 黎 <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
