Yair Zaslavsky has posted comments on this change.
Change subject: core: Adds entity DwhHistoryTimekeeping and variable heartBeat
......................................................................
Patch Set 1:
(4 comments)
what about fixtures.xml? changes are not needed there?
thanks!
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DwhHistoryTimekeeping.java
Line 57: this.dateTime = datetTime;
Line 58: }
Line 59:
Line 60: @Override
Line 61: public String getId() {
Do we gain anything from ID setters and getters?
Usually this should be a field representing a PK in DB.
Not all business entities have to imlement BussinessEntity.
You have to implement when you want to use the compensation mechanism.
Line 62: return variable.getVarName();
Line 63: }
Line 64:
Line 65: @Override
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/dwh/DwhHistoryTimekeepingDaoImpl.java
Line 8: import org.ovirt.engine.core.dal.dbbroker.DbFacadeUtils;
Line 9: import org.ovirt.engine.core.dao.BaseDAODbFacade;
Line 10: import org.springframework.jdbc.core.RowMapper;
Line 11:
Line 12: public class DwhHistoryTimekeepingDaoImpl extends BaseDAODbFacade
implements DwhHistoryTimekeepingDao {
Should be DwhHistoryTimekeepingDaoDbFacadeImpl
Line 13: private static class DwhHistoryTimekeepingMapper implements
RowMapper<DwhHistoryTimekeeping> {
Line 14: public static final DwhHistoryTimekeepingMapper instance = new
DwhHistoryTimekeepingMapper();
Line 15:
Line 16: @Override
Line 10: import org.springframework.jdbc.core.RowMapper;
Line 11:
Line 12: public class DwhHistoryTimekeepingDaoImpl extends BaseDAODbFacade
implements DwhHistoryTimekeepingDao {
Line 13: private static class DwhHistoryTimekeepingMapper implements
RowMapper<DwhHistoryTimekeeping> {
Line 14: public static final DwhHistoryTimekeepingMapper instance = new
DwhHistoryTimekeepingMapper();
why not private or protected?
Line 15:
Line 16: @Override
Line 17: public DwhHistoryTimekeeping mapRow(ResultSet rs, int rowNum)
throws SQLException {
Line 18: DwhHistoryTimekeeping entity = new DwhHistoryTimekeeping();
....................................................
File packaging/dbscripts/upgrade/03_03_0900_add_dwh_heartbeat.sql
Line 1: Insert into dwh_history_timekeeping
VALUES('heartBeat',NULL,to_timestamp('01/01/2000', 'DD/MM/YYYY'));
We try to somehow maintain some convention, I know it's hard and we have lots
of mess
Use INSERT INTO , thanks :)
--
To view, visit http://gerrit.ovirt.org/19366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib34301ea921b2fda9fb0e09927b0417c0c096aca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
