Daniel Erez has posted comments on this change.
Change subject: engine: Cleanup of HotPlugDiskToVmCommand
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 79: }
Line 80:
Line 81: oldVmDevice = getVmDeviceDao().get(new
VmDeviceId(disk.getId(), getVmId()));
Line 82: if (getPlugAction() == VDSCommandType.HotPlugDisk &&
oldVmDevice.getIsPlugged()) {
Line 83: return
failCanDoAction(VdcBllMessages.HOT_PLUG_DISK_IS_NOT_UNPLUGGED);
formatter
Line 84: }
Line 85:
Line 86: if (getPlugAction() == VDSCommandType.HotUnPlugDisk &&
!oldVmDevice.getIsPlugged()) {
Line 87: return
failCanDoAction(VdcBllMessages.HOT_UNPLUG_DISK_IS_NOT_PLUGGED);
Line 83: return
failCanDoAction(VdcBllMessages.HOT_PLUG_DISK_IS_NOT_UNPLUGGED);
Line 84: }
Line 85:
Line 86: if (getPlugAction() == VDSCommandType.HotUnPlugDisk &&
!oldVmDevice.getIsPlugged()) {
Line 87: return
failCanDoAction(VdcBllMessages.HOT_UNPLUG_DISK_IS_NOT_PLUGGED);
formatter
Line 88: }
Line 89:
Line 90: return true;
Line 91: }
--
To view, visit http://gerrit.ovirt.org/19302
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cdc4e19da8768af9cd6659763af622b3e630e1d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
