Daniel Erez has posted comments on this change.
Change subject: core: Architecture related queries
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCompatibleVmTemplatesByStoragePoolAndArchitectureQuery.java
Line 20:
Line 21: @Override
Line 22: protected void executeQueryCommand() {
Line 23: StoragePool pool =
DbFacade.getInstance().getStoragePoolDao().get(getParameters().getId());
Line 24: SearchParameters p = new
SearchParameters(String.format("Templates: DataCenter = %1$s", pool.getName()),
If this query is used by the user portal, you can't use search as the result
won't be filtered according to user's permissions. Instead, create a new stored
procedure that takes into account the 'is_filtered' flag (e.g.
GetAllFromVmTemplates). Preferably, convert GetVmTemplatesByStoragePoolIdQuery
to a user query (i.e. filtered by user's permissions).
Line 25: SearchType.VmTemplate);
Line 26: p.setMaxCount(Integer.MAX_VALUE);
Line 27: VdcQueryReturnValue returnValue =
Backend.getInstance().runInternalQuery(VdcQueryType.Search, p);
Line 28:
--
To view, visit http://gerrit.ovirt.org/17855
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ee9cbece6b06893c0101e074e21ca5ab6a8e561
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
