Omer Frenkel has posted comments on this change.
Change subject: core,ui: VirtIO-SCSI enabled flag
......................................................................
Patch Set 8:
(1 comment)
much better, thanks, one issue inside
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 367:
Line 368: if
(Boolean.TRUE.equals(getParameters().isVirtioScsiEnabled()) &&
Line 369:
!FeatureSupported.virtIoScsi(getVdsGroup().getcompatibility_version())) {
Line 370: return
failCanDoAction(VdcBllMessages.VIRTIO_SCSI_INTERFACE_IS_NOT_AVAILABLE_FOR_CLUSTER_LEVEL);
Line 371: }
this shouldn't be changed if vm is not down
Line 372:
Line 373: return true;
Line 374: }
Line 375:
--
To view, visit http://gerrit.ovirt.org/18638
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice06fda5946b5961cfe9c819b0b368525b1f4b58
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
