Yair Zaslavsky has posted comments on this change.
Change subject: engine: Introduced InternalJob and InternalStep command
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalJobCommand.java
Line 23: @Override
Line 24: protected boolean canDoAction() {
Line 25:
Line 26: boolean retValue = super.canDoAction();
Line 27: if (getParameters().getActionType() == null) {
Not sure how this can happen? please elaborate.
Line 28:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_EMPTY_ACTIONTYPE);
Line 29: retValue = false;
Line 30: }
Line 31: return retValue;
--
To view, visit http://gerrit.ovirt.org/19182
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17074d4317c037fa9fcc680f4b0a7a9b3a6b087a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
