Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: revert nfs config on cleanup ......................................................................
Patch Set 2: (2 comments) .................................................... Commit Message Line 6: Line 7: packaging: setup: revert nfs config on cleanup Line 8: Line 9: Revert /etc/sysconfig/nfs to its original contents on cleanup. Line 10: Also fix some of its settings for recent Fedora nfs-utils. hmm... this should be separate patch? what about old fedora? rhel? cents? Line 11: Line 12: Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854 Line 13: Signed-off-by: Sandro Bonazzola <[email protected]> .................................................... File packaging/setup/plugins/ovirt-engine-setup/system/nfs.py Line 57: \s* Line 58: .* Line 59: $ Line 60: """ Line 61: ) I thought we just add stuff... like a template... but I see your point. I suggest you move this code to util module? Line 62: Line 63: def _editParams(self, params, content): Line 64: newcontent = [] Line 65: for line in content.splitlines(): -- To view, visit http://gerrit.ovirt.org/19001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
