Maor Lipchuk has posted comments on this change.
Change subject: engine: Split update of 'isPlugged' and 'bootOrder'
properties...
......................................................................
Patch Set 10:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 120: private void updateBootOrder() {
Line 121: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Line 122: @Override
Line 123: public Void runInTransaction() {
Line 124:
VmDeviceUtils.updateBootOrderInVmDeviceAndStoreToDB(getVm().getStaticData());
When are we incrementing the db generation now
Line 125: return null;
Line 126: }
Line 127: });
Line 128: }
Line 157: public String getDiskAlias() {
Line 158: return disk.getDiskAlias();
Line 159: }
Line 160:
Line 161: public Disk getDisk() {
Please use protected here
Line 162: if (disk == null) {
Line 163: disk = getDiskDao().get(getParameters().getDiskId());
Line 164: }
Line 165: return disk;
--
To view, visit http://gerrit.ovirt.org/19311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1359a34a48a6261e22631ff1640d81d735e8c490
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
