Kanagaraj M has posted comments on this change.
Change subject: webadmin: Status display after stopping rebalance
......................................................................
Patch Set 5:
(2 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 590: cModel.stopProgress();
Line 591:
cModel.setMessage(ConstantsManager.getInstance().getMessages().rebalanceStatusConfirmationMessage(volumeEntity.getName()));
Line 592: cModel.getCommands().add(rebalanceStatusOk);
Line 593: } else {
Line 594: cModel.stopProgress();
Can this be moved up to avoid repetition?
Line 595: setConfirmWindow(null);
Line 596: VolumeRebalanceStatusModel rebalanceStatusModel =
Line 597: new
VolumeRebalanceStatusModel(volumeEntity);
Line 598:
rebalanceStatusModel.setTitle(ConstantsManager.getInstance()
Line 613:
if(rebalanceStatusEntity.getStatusSummary().getStatus() ==
JobExecutionStatus.FINISHED) {
Line 614: rebalanceStopFromStatus.setIsAvailable(false);
Line 615: } else {
Line 616: rebalanceStopFromStatus.setIsAvailable(true);
Line 617: }
If the rebalance is stopped using the 'Stop' button in the status dialog, is
the same status dialog used to show the status or it will be shown in a new
dialog?
Line 618:
Line 619:
Line 620: UICommand cancelRebalance = new
UICommand("CancelRebalanceStatus", VolumeListModel.this);//$NON-NLS-1$
Line 621:
cancelRebalance.setTitle(ConstantsManager.getInstance().getConstants().close());
--
To view, visit http://gerrit.ovirt.org/19402
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66c44df37b20b4454d51aacc58e8a4a33794318f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
